feat/phase-6-settings: editable settings + Velopack updater (stacked on #8)#9
Merged
Conversation
Settings page becomes interactive:
- Theme combo (System/Light/Dark) applies live via IThemeApplier ->
MainWindow.Content.RequestedTheme.
- Close behaviour combo (Hide-to-tray vs Exit) persists immediately.
- Hotkey + storage location shown read-only with a note about future
rebind / move support.
About expander reads real assembly metadata (InformationalVersion,
copyright) from Directory.Build.props.
WindowsUpdateService wraps Velopack's UpdateManager pointed at the
StuartMeeks/Snipdeck GitHub releases. Check button surfaces the available
version; Apply button (visible only when an update is available) downloads
and restarts. Dev builds gracefully no-op via UpdateManager.IsInstalled.
ShellViewModel.OpenSettings now takes a SettingsViewModel parameter —
ShellPage code-behind resolves it from DI on each click so the page reads
fresh config state.
New abstractions: IThemeApplier, IUpdateService.
New App services: WindowsThemeApplier, WindowsUpdateService.
This PR is the fourth and last in the stack. Base: feat/phase-5-platform.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ne the null check CA2016: pass cancellationToken through to Velopack's DownloadUpdatesAsync via its cancelToken named parameter. IDE0046: fold the trailing null check into a single ternary return so the analyser stops asking for it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The Phase 4-6 PRs trimmed several items to stay reviewable. Capture them here with enough detail to pick up cold: hotkey rebinding UI, storage path move/adopt/conflict flow, configurable backup retention, CLI delete cascade decision, NBGV integration, markdown rendering for descriptions, trash UI. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 6 — the last in the stack. Settings becomes interactive and the Velopack updater wakes up.
Base: `feat/phase-5-platform` (PR #8). Once the stack merges, please retarget this PR to `master` and rebase.
What's live
New abstractions
New App services
Tests
106 Core tests still passing. New test doubles for the new abstractions:
`FakeThemeApplier`, `FakeUpdateService`, `FakePathProvider`, `FakeSettingsStore`.
Deferred (parked in TODO.md or follow-up)
What CI doesn't verify (please test)
🤖 Generated with Claude Code